Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test node tree browsing #19

Open
spbnick opened this issue Nov 16, 2021 · 5 comments
Open

Add test node tree browsing #19

spbnick opened this issue Nov 16, 2021 · 5 comments

Comments

@spbnick
Copy link
Collaborator

spbnick commented Nov 16, 2021

Now that we've more-or-less implemented test node summarizing, add a panel listing top-level nodes to the Home dashboard, and a dashboard for a (context-less) test node. Add panels to list recent executions of tests at and under the node, as well as status trends.

@spbnick
Copy link
Collaborator Author

spbnick commented Mar 3, 2022

@fooishbar has also requested this.

@spbnick
Copy link
Collaborator Author

spbnick commented Mar 3, 2022

Also consider adding filtering of revisions/checkouts/builds by tests executed for them.

@spbnick
Copy link
Collaborator Author

spbnick commented Mar 4, 2022

Detailed usecases: kernelci/kernelci-project#28 (comment)

@spbnick
Copy link
Collaborator Author

spbnick commented Jun 15, 2022

Here's the log of our chat with @fooishbar regarding this:

[2022-03-03 17:28:49] <daniels> spbnick: hey there, I'm working on the gfx stack, and one thing which would be really nice is a per-testsuite view to KCIDB
[2022-03-03 17:29:33] <daniels> spbnick: for example, I'm really interested to see what igt-gpu-panfrost looks like across all trees, rather than having to pick a specific source/tree/kconfig, and only then being able to get an aggregated view of all test suites
[2022-03-03 17:29:45] <spbnick> daniels: Hi Daniel! Nice to see you drop by 😁
[2022-03-03 17:30:05] <daniels> spbnick: is there any chance kci could grow something like that? I think it would be a good way to drag in people who care about particular subsystems (gfx, v4l2, whatever) and want a quick overview of the health of their test suites
[2022-03-03 17:30:06] <daniels> o/
[2022-03-03 17:30:47] <spbnick> daniels: Ah, yes. I've actually been thinking about adding it for the last release, but ran out of time. Let me add a todo and an issue for that.
[2022-03-03 17:31:34] <spbnick> daniels: By "kci" do you mean the dashboard on https://linux.kernelci.org/ ?
[2022-03-03 17:32:56] <spbnick> daniels: Yes, I agree, it would be useful. Do we already have the graphics tests in KCIDB? Can you give me a link to a result, so I could have a sample?
[2022-03-03 17:32:58] <daniels> spbnick: thanks, that's cool! so I was thinking about both https://linux.kernelci.org/test/ (and searching for the test suite name, which is kind of tedious), as well as https://kcidb.kernelci.org/d/home/home?orgId=1
[2022-03-03 17:33:45] <daniels> spbnick: https://linux.kernelci.org/test/job/next/branch/master/kernel/next-20220303/plan/igt-gpu-panfrost/ is a sample; generally anything with the test plan name igt-gpu-.*
[2022-03-03 17:34:46] <spbnick> daniels: In the KCIDB's Grafana dashboard you would be able to enter the exact "test path" and get result for that test and its subtests. Do you also need to be able to display results for partial "test path" matches, or do you want to maybe search test "comments"?
[2022-03-03 17:36:16] <daniels> spbnick: to be honest I have absolutely no idea what the difference is between a test path and a test comment ;) assuming in the above link that igt-gpu-panfrost is the 'test plan name', I want to be able to filter on one or more test plan names
[2022-03-03 17:37:47] <spbnick> daniels: Right, the KernelCI test plan name goes into KCIDB "test path" right now. It will likely change later, but we'll keep your usecase in mind and think of something.
[2022-03-03 17:38:34] <daniels> spbnick: filtering options which would be useful, e.g. 'I want to see how IGT looks generally for the next release' -> (URL == next + test-plan-names == (igt-gpu-panfrost|igt-gpu-i915|igt-gpu-amd))
[2022-03-03 17:38:55] <daniels> 'I want to see how the Panfrost driver is doing across all dev trees' -> (origin == kernelci + test-plan-names == igt-gpu-panfrost)
[2022-03-03 17:38:58] <spbnick> daniels: Unfortunately, I don't see any test results for that revision in KCIDB for some reason: https://kcidb.kernelci.org/d/revision/revision?orgId=1&var-git_commit_hash=91265a6da44d13296bdb5b3fbafa19d06be462f2&var-patchset_hash=
[2022-03-03 17:39:15] <spbnick> Maybe they got lost on submission from KernelCI native system?
[2022-03-03 17:39:46] <daniels> no idea tbh ... gtucker might know I suppose?
[2022-03-03 17:40:02] <spbnick> daniels: Are you able to find any results for graphics tests in KCIDB itself, not on the https://linux.kernelci.org/ dashboards?
[2022-03-03 17:41:10] <daniels> spbnick: afaict, the only way to find particular test results in KCIDB is if you narrow down to a particular commit?
[2022-03-03 17:41:30] <daniels> the front page just gives me the raw number of tests which pass/fail/etc: https://kcidb.kernelci.org/d/home/home?orgId=1&refresh=30m
[2022-03-03 17:42:10] <daniels> selecting e.g. master of torvalds from the repos link still only shows me the raw number of pass/fail tests, not letting me filter them: https://kcidb.kernelci.org/d/repository/repository?orgId=1&var-dataset=kcidb_01&var-origin=All&var-build_architecture=All&var-build_config_name=All&var-git_repository_url=https:%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git
[2022-03-03 17:43:34] <daniels> (actually, I think those tests only run on kernelci, not on google/rh/arm/etc, so let's back up and filter the origin to kernelci from the main page)
[2022-03-03 17:43:45] <spbnick> daniels: Yeah, right now you have to pick a revision, a checkout, or a build first.
[2022-03-03 17:44:31] <daniels> hmm, I think something is wrong, because filtering by origin==kernelci from the home page now returns me no data at all ...
[2022-03-03 17:44:38] <spbnick> daniels: We can maybe work on adding filtering by executed tests to the revision/checkout/build lists.
[2022-03-03 17:45:16] <spbnick> daniels: Uh-oh. There were some problems with KernelCI submissions recently, maybe that's why. Try selecting a wider time range in the top right corner.
[2022-03-03 17:46:34] <daniels> hmmm, I tried to navigate to one of the arm revisions, which threw up about a billion Grafana errors about malformed AJAX responses
[2022-03-03 17:46:39] <daniels> now kcidb.kernel.org isn't responding at all
[2022-03-03 17:47:51] <spbnick> daniels: Whoa, that's new :D
[2022-03-03 17:49:05] <spbnick> gtucker, mgalka: Is it right that KCIDB haven't got any data for mainline from KernelCI since the end of January? Here: https://kcidb.kernelci.org/d/repository/repository?orgId=1&var-dataset=kcidb_01&var-git_repository_url=https:%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&var-origin=kernelci&var-build_architecture=All&var-build_config_name=All&from=now-90d&to=now
[2022-03-03 17:49:17] <spbnick> daniels: Hmm, it works for me. E.g. check the link above.
[2022-03-03 17:50:28] <daniels> oh, it works in an incognito window. I guess all the failures just DoSed Chrome and left me with too many hung sockets/workers
[2022-03-03 17:51:11] <spbnick> daniels: Sorry about that!
[2022-03-03 17:51:20] <daniels> right, so here's the misery when I try to navigate to a specific commit ID, so I can look at the test results https://usercontent.irccloud-cdn.com/file/ZZaCaWai/Screenshot%20from%202022-03-03%2015-51-00.png
[2022-03-03 17:51:40] <daniels> spbnick: nothing to apologise for :)
[2022-03-03 17:51:54] <daniels> just trying to figure out how I can best give you suggestions/feedback for this workflow
[2022-03-03 17:52:12] <spbnick> daniels: Yeah, probably something server-side went wrong :/
[2022-03-03 17:52:15] <spbnick> Thanks :)
[2022-03-03 17:52:20] <daniels> np!
[2022-03-03 17:53:59] <daniels> if you ever want me to take a look at stuff, just prod me here or cc @fooishbar on GH
[2022-03-03 17:54:30] <spbnick> I gotta run right now, but I'll check up on your messages in an hour or so. Thanks for all the suggestions! Would be great if you could find your tests in KCIDB, or give me a list or even a regex to look for, so I have real data to aim at :)
[2022-03-03 17:54:36] <spbnick> daniels: Will do, thanks!
[2022-03-03 17:56:43] <daniels> heh yeah, I’ll see if kcidb recovers; nothing urgent anyway, we were just talking on dri-devel@ about getting IGT more widely enabled, so I was trying to find something I could suggest for people to see those
[2022-03-03 17:56:47] <daniels> thanks, enjoy!

@spbnick
Copy link
Collaborator Author

spbnick commented Jun 20, 2022

Alright, here's my stab at it @fooishbar: https://kcidb.kernelci.org/d/test-node/test-node?var-test_path=igt-gpu-panfrost

The above would display data on the igt-gpu-panfrost "test node" (basically "test", we gotta fix our vocabulary)

You can construct links to the other tests in a similar manner, navigate to other tests inside that dashboard, and you can also see the full list of top-level tests from the home page, of course.

Please take a look and tell me what you want changed or added 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant