Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds table rows stay expanded by index even when changing statusFilter #442

Open
MarceloRobert opened this issue Oct 28, 2024 · 0 comments

Comments

@MarceloRobert
Copy link
Collaborator

When expanding a build row in the builds table of a tree details, changing the status filter above (all, successful, failed, inconclusive) will keep the row expanded by index, not by the specific row. That means, if I expand the first row - a successful build with no fails - and then change to only failed builds, the first row of the failed builds will still be expanded, even if it is different than the one I had expanded before.

How to test:

Go to a tree details with successful and failed builds, expand a row that has 0 errors, set the status filter to "failed", the failed build row - with the index of the row you expanded before - will also be expanded, even if the builds are different.
Test URL: http://localhost:5173//tree/519b8651aaf6784a00935519bb68c3fae6e8f8e4?tableFilter=%7B%22buildsTable%22%3A%22all%22%2C%22bootsTable%22%3A%22all%22%2C%22testsTable%22%3A%22all%22%7D&origin=maestro&currentTreeDetailsTab=treeDetails.builds&diffFilter=%7B%7D&treeInfo=%7B%22gitBranch%22%3A%22android-mainline%22%2C%22gitUrl%22%3A%22https%3A%2F%2Fandroid.googlesource.com%2Fkernel%2Fcommon%22%2C%22treeName%22%3A%22android%22%2C%22commitName%22%3A%22v6.12-rc3-6467-g519b8651aaf67%22%2C%22headCommitHash%22%3A%22519b8651aaf6784a00935519bb68c3fae6e8f8e4%22%7D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant