Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups app frontend validations and alerts #32

Open
rorysaur opened this issue Jun 1, 2022 · 2 comments
Open

Groups app frontend validations and alerts #32

rorysaur opened this issue Jun 1, 2022 · 2 comments
Assignees
Labels

Comments

@rorysaur
Copy link
Contributor

rorysaur commented Jun 1, 2022

In the Groups app create/edit form:

  1. Name cannot be blank.
  2. Member IDs cannot be blank.
  3. Member IDs must be in the correct format (comma-delineated strings) AND each member ID must correspond to an existing member. (This entire validation will be unnecessary once Add autocomplete to add members to a group by name #30 is completed.)

Validate these on Save.

  1. If all validations pass and the save is successful, there should be an alert below the Save button saying:
    a. for create: "Your group has been created! [View your group.] (with link to the group's View page)"
    b. for edit: "Your changes have been saved! [View your group.] (ditto)"
  2. If any validations fail:
    a. There should be an alert below the Save button saying: "Something went wrong. Check for errors above."
    b. There should be a message below each failing field specifying what the problem is.
  3. If all validations pass but the save fails for any reason, there should be an alert saying: "Something went wrong." with the error message appended if there is one.

Additionally, gray out and disable the Save button while waiting for the save.

See the Adventures create/edit form (ProjectForm) for examples of all of the above, including per-field validations and validation messages, success and error alerts, how to link to the new entity's page, and disabling the Save button.

@rorysaur rorysaur added the ux label Jun 1, 2022
@thestrabusiness
Copy link

Will take a shot at this!

@thestrabusiness
Copy link

Got a draft PR opened just now. Still need to clean some things up which I should be able to take a shot at tomorrow evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants