Error with no domain specified #38
-
|
I am getting this error when I omitted the DOMAIN variable. The instruction allows for no domain. Femi |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
|
Hey, I took a look at the code and realized that even though checking the case where traefik-certs-dumper/bin/dump.sh Line 334 in d2f15d1 We simply have to remove this check and rewrite it to only split the If you want, you can try to fix it and send in a PR. Otherwise I fix it as soon as possible. Thanks for pointing this out! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your response. |
Beta Was this translation helpful? Give feedback.
-
|
No problem. I take care of it :) |
Beta Was this translation helpful? Give feedback.
-
|
Did you try to pull the latest image? I took a look at the code again and actually, it should just log this: |
Beta Was this translation helpful? Give feedback.
Hey,
I took a look at the code and realized that even though checking the case where
DOMAINis empty, I probably forgot to remove the sanity check where the program would exit ifDOMAINis empty.traefik-certs-dumper/bin/dump.sh
Line 334 in d2f15d1
We simply have to remove this check and rewrite it to only split the
DOMAINCSVs ifDOMAINis defined.If you want, you can try to fix it and send in a PR. Otherwise I fix it as soon as possible. Thanks for pointing this out!