Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation Album, Multi Disc, not rendered correctly #49

Open
frontegi opened this issue Jan 26, 2025 · 5 comments
Open

Compilation Album, Multi Disc, not rendered correctly #49

frontegi opened this issue Jan 26, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@frontegi
Copy link

Hi @faultables,
just want to help, finding strange behaviours.

The facts:
I've a lot of compilation in my Navidrome.
For each song I've lost some nights setting those tag (to have a nice view and order in Navidrome) :

  • the TAG COMPILATION = 1 , so I can filter them directly in Navidrome and have only compilation on screen.
  • the track number
  • for multi disc compilation, the disc number.
  • I set Album Artist tag as "Compilation", but it can be any string.
    In this way I can achieve the following view in Navidrome ( and it was the same with iTunes):

Image

So the player can playback in the correct order, and songs are grouped.

For the same disc, in Flo, I get:

Image

So, for example the Album Artist is shown as Paul McCartney (Track08 of CD2 )
And the songs are in the order:
CD1-track1
CD2-track1
CD1-track2
CD2-track2

Probably you have to find a way to handle multi disc albums.
If you need some sample files with these tag set, for testing, let me know.
I can prepare a demo package.

@faultables
Copy link
Contributor

So, for example the Album Artist is shown as Paul McCartney (Track08 of CD2 )

Is this expected or should we display it as "Compilation"? Currently I do a "dirty way" to trick the UI when an album has multiple artists (as long as the album artist is "Various Artists") like this:

Image

And I think need to fix that

And the songs are in the order:
CD1-track1
CD2-track1
CD1-track2
CD2-track2

Probably you have to find a way to handle multi disc albums.

Yeah currently the ordering method is pretty simple and naive, and I will let you know when I need some help!

@faultables faultables added the enhancement New feature or request label Jan 26, 2025
@frontegi
Copy link
Author

Yes, correct. I think that if track has the "album artist" tag, you have to use exactly that field.
In my specific case, I have set "Album artist"="Compilation", but it has been a personal choice.

Tipically I set the same "Album Artist" for all tracks of a Compilation, so that navidrome group them all under a single album.
Itunes has the same behaviour.

Instead, if there is no "Album Artist" Tag, but you have Artist in the track, I think it's up to you what to show in the Album View.

I added to all my "Various Artists" album, the tag COMPILATION=1, so that I can have all the Compilation filtered by Navidrome:

Image

Only one question, since I don't know how the app interact with the Server/Navidrome.
Why not inheriting the Album Artist label, directly from Navidrome, without adding further logic ?
I think at the same way you retrieve the Album Art Cover.
(Clearly I don't know if this is something you can obtain, while reading the remote tracks/album list).

@faultables
Copy link
Contributor

Why not inheriting the Album Artist label, directly from Navidrome, without adding further logic ?

actually i do. the different is, i don't show the "artist name" by default if the current album is belong to the same (one) artist

...and flo currently does not treat disc numbers properly which is different from the Navidrome Web UI (gonna fix it!)


I don't know exactly why flo shows "Paul McCartney & Wings" instead of "Compilations", would you mind sharing the JSON response for that album? IIRC flo displays whatever the album.name is, but looking at your Navidrome Web UI screenshot I think something is wrong with flo

@frontegi
Copy link
Author

frontegi commented Jan 27, 2025

Just retrieved the json.
In fact it seems that in Flo you read the "artist" tag (Paul McCartney), while I was expecting the "albumArtist" tag.
I think the latter is the correct one, but curious that under the hood Navidrome return a random artist from the track 8 of the 2nd disc, for the Album!

Here is the JSON :

{
    "playCount": 25,
    "playDate": "2025-01-22T16:24:09.369Z",
    "rating": 0,
    "starred": false,
    "starredAt": null,
    "id": "23690a96823b078d1574ee93933f4ece",
    "libraryId": 1,
    "name": "Music Of The Millennium",
    "embedArtPath": "",
    "artistId": "9264224b1abb52310c3e9f86a2f1994b",
    "artist": "Paul McCartney \u0026 Wings",
    "albumArtistId": "19abb2703b248c44277c886940771cec",
    "albumArtist": "Compilation",
    "allArtistIds": "04594560ae5c3bbc152fbfde3adfd187 093aee7b361e9e77502f945da86f9967 0f3147d9617809f66aeca57105ca344a 122ebaeff577a79d476913956779dc6d 15a3f278205000cd8a81dd894cc0179e 19abb2703b248c44277c886940771cec 1d8b1a417cded2f7c51ba47248ecf777 1f145ead2553e555af32d48870616c73 1ff7ce650a770eeb2f972518bfc633c4 2077e4a6bafa9b4e7b55e1fff16818af 22cb5341b90c54b33d4a4173353257f4 270c1b084f3f146eb5787075158d9c53 27db600b408814bac570d2fa2993f79b 333c75b20710bdccddce0f802a811dbb 335ffbcfac66fb164e9d5a54505cad8f 3e194b5730ed8b868224b80ac8d7eed9 4026ef4c21b2b9d8231f5f16d5eb3e2f 48c3c6f91e5607c0446cc12a8d59af97 4af5059f5ae2a61a6cf1f4bbd7e852c5 4ce5fb83b6365e19e75049dd56c771de 54a8723466e5d487247f3d93d51c66bc 59a3c84dabcdd637e8cc3c850e0b9255 72545f3f86fad045a26ed54abd2bbb9f 85c7bf4e545d2a0c25afe91b2b443f86 9264224b1abb52310c3e9f86a2f1994b a5b25a79f42c603a3cfdfeb430ba4907 ad3681d67e96dba5cc3913a1cb0ba875 ae8f08b74ddf00f98ff437973add51f3 b3852d20a9aa39afb756abec1f5fea3b b8cd6be222d596ad9c3a8c2f7e2f3b63 c39ac31a9e0a69abbafe5ec347a8c8f6 c7a178eef349245d0352efa79a24c536 d05560f6566db54140c1c5adf58cf70f d6499b91900ef1b2db35d04457846c05 e0c5c9958dd3d5f2ba4ac75a8d108957 e3a245cff2f35d106537732eb4b04c5e e4855f4f140ecad0c4935ac3744eec10 e5c064345d48f9d0a65b4ff9f4d786d3 e770281e978acf9b92379a113e95f0ad eaf66c1442860f0b7d9fe19d0d0f612e",
    "maxYear": 2000,
    "minYear": 2000,
    "date": "2000",
    "maxOriginalYear": 0,
    "minOriginalYear": 0,
    "releases": 1,
    "compilation": true,
    "songCount": 39,
    "duration": 9461.56,
    "size": 151484762,
    "genre": "",
    "genres": null,
    "discs": {
        "1": "",
        "2": ""
    },
    "orderAlbumName": "music of the millennium",
    "orderAlbumArtistName": "compilation",
    "imageFiles": "/music/Compilations/Millennium Compilation/cover.jpg",
    "paths": "/music/Compilations/Millennium Compilation",
    "externalUrl": "https://www.last.fm/music/+noredirect/Compilation/Music+of+the+Millennium",
    "externalInfoUpdatedAt": "2025-01-22T15:06:25.747353642Z",
    "createdAt": "2025-01-18T03:26:39.005633772Z",
    "updatedAt": "2025-01-21T01:15:51.541Z"
}

@faultables
Copy link
Contributor

thanks for the JSON. i think i now how to handle that album artist thing without using my dirty way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants