Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with truncated hashes #40

Open
lnicola opened this issue Jan 17, 2021 · 3 comments · May be fixed by #43
Open

Doesn't work with truncated hashes #40

lnicola opened this issue Jan 17, 2021 · 3 comments · May be fixed by #43

Comments

@lnicola
Copy link

lnicola commented Jan 17, 2021

$ rustup-toolchain-install-master c963187
detecting the channel of the `c963187` toolchain...
error: toolchain `c963187` doesn't exist in any channel

$ rustup-toolchain-install-master c963187c6f959417cbb13a33e9eaea4607696fc4                                                                                               1 ✘ 
detecting the channel of the `c963187c6f959417cbb13a33e9eaea4607696fc4` toolchain...
downloading <https://ci-artifacts.rust-lang.org/rustc-builds/c963187c6f959417cbb13a33e9eaea4607696fc4/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz>...
50.60 MB / 50.60 MB [========================================================================================================================================================================] 100.00 % 11.49 MB/s 
downloading <https://ci-artifacts.rust-lang.org/rustc-builds/c963187c6f959417cbb13a33e9eaea4607696fc4/rust-std-nightly-x86_64-unknown-linux-gnu.tar.xz>...
24.49 MB / 24.49 MB [========================================================================================================================================================================] 100.00 % 10.94 MB/s 
toolchain `c963187c6f959417cbb13a33e9eaea4607696fc4` is successfully installed!

I'm not sure if it's possible to find the matching build for a truncated hash, but an error message might be useful here.

@hellow554
Copy link
Contributor

hellow554 commented Aug 11, 2021

Looks really similar to rust-lang/cargo-bisect-rustc#20 which was fixed by (me 🙈 ) @ rust-lang/cargo-bisect-rustc#33

It should be possible to do something similar here

@lnicola
Copy link
Author

lnicola commented Sep 14, 2021

The problem is that this project doesn't use git as a dependency.

I think a reasonable solution would be to check the revision string length and warn in a more friendly way.

@lnicola lnicola linked a pull request Sep 14, 2021 that will close this issue
@lnicola
Copy link
Author

lnicola commented Sep 14, 2021

Filed #43 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants