From 649c5a7a11d61c2fd66e1aecaf035b969aa9f2a7 Mon Sep 17 00:00:00 2001
From: Tal <tal@keephq.dev>
Date: Wed, 13 Nov 2024 15:35:31 +0200
Subject: [PATCH] chore(pagerduty): support event type in routing key (#2475)

---
 .../pagerduty_provider/pagerduty_provider.py  | 25 +++++++++++++++----
 pyproject.toml                                |  2 +-
 2 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/keep/providers/pagerduty_provider/pagerduty_provider.py b/keep/providers/pagerduty_provider/pagerduty_provider.py
index fd8318278..eac09653d 100644
--- a/keep/providers/pagerduty_provider/pagerduty_provider.py
+++ b/keep/providers/pagerduty_provider/pagerduty_provider.py
@@ -319,7 +319,11 @@ def validate_scopes(self):
         return scopes
 
     def _build_alert(
-        self, title: str, alert_body: str, dedup: str
+        self,
+        title: str,
+        alert_body: str,
+        dedup: str,
+        event_type: typing.Literal["trigger", "acknowledge", "resolve"] = "trigger",
     ) -> typing.Dict[str, typing.Any]:
         """
         Builds the payload for an event alert.
@@ -328,13 +332,14 @@ def _build_alert(
             title: Title of alert
             alert_body: UTF-8 string of custom message for alert. Shown in incident body
             dedup: Any string, max 255, characters used to deduplicate alerts
+            event_type: The type of event to send to PagerDuty
 
         Returns:
             Dictionary of alert body for JSON serialization
         """
         return {
             "routing_key": self.authentication_config.routing_key,
-            "event_action": "trigger",
+            "event_action": event_type,
             "dedup_key": dedup,
             "payload": {
                 "summary": title,
@@ -346,7 +351,13 @@ def _build_alert(
             },
         }
 
-    def _send_alert(self, title: str, body: str, dedup: str | None = None):
+    def _send_alert(
+        self,
+        title: str,
+        body: str,
+        dedup: str | None = None,
+        event_type: typing.Literal["trigger", "acknowledge", "resolve"] = "trigger",
+    ):
         """
         Sends PagerDuty Alert
 
@@ -354,6 +365,7 @@ def _send_alert(self, title: str, body: str, dedup: str | None = None):
             title: Title of the alert.
             alert_body: UTF-8 string of custom message for alert. Shown in incident body
             dedup: Any string, max 255, characters used to deduplicate alerts
+            event_type: The type of event to send to PagerDuty
         """
         # If no dedup is given, use epoch timestamp
         if dedup is None:
@@ -361,7 +373,7 @@ def _send_alert(self, title: str, body: str, dedup: str | None = None):
 
         url = "https://events.pagerduty.com/v2/enqueue"
 
-        payload = self._build_alert(title, body, dedup)
+        payload = self._build_alert(title, body, dedup, event_type)
         result = requests.post(url, json=payload)
         result.raise_for_status()
 
@@ -496,6 +508,7 @@ def _notify(
         service_id: str = "",
         requester: str = "",
         incident_id: str = "",
+        event_type: typing.Literal["trigger", "acknowledge", "resolve"] = "trigger",
         **kwargs: dict,
     ):
         """
@@ -507,7 +520,9 @@ def _notify(
             kwargs (dict): The providers with context
         """
         if self.authentication_config.routing_key:
-            return self._send_alert(title, alert_body, dedup=dedup)
+            return self._send_alert(
+                title, alert_body, dedup=dedup, event_type=event_type
+            )
         else:
             return self._trigger_incident(
                 service_id, title, alert_body, requester, incident_id
diff --git a/pyproject.toml b/pyproject.toml
index 390c1f11e..12520a94b 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "keep"
-version = "0.28.8"
+version = "0.28.9"
 description = "Alerting. for developers, by developers."
 authors = ["Keep Alerting LTD"]
 readme = "README.md"