Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injected browser buttons visible in weird places (Firefox) #2444

Open
1 task done
ygoe opened this issue Jan 27, 2025 · 4 comments
Open
1 task done

Injected browser buttons visible in weird places (Firefox) #2444

ygoe opened this issue Jan 27, 2025 · 4 comments

Comments

@ygoe
Copy link

ygoe commented Jan 27, 2025

Have you searched for an existing issue?

  • Yes, I tried searching and reviewed the pinned issues

Brief Summary

The Firefox browser extension adds buttons to form fields it believes might be login fields. That works more or less well, but for the application I'm currently developing, it's not working at all. Here's a part of the form with the added button:

Image

There's that TOTP button on a disabled checkbox. And even worse, it won't go away when a full-page modal opens:

Image

It's on top of the content and can't be removed. It's always there and sometime seven scrolls wildly over the page. After a while using the app, it may go away.

What's triggering this and how can I prevent that? (Without uninstalling the extension.)

Steps to Reproduce

See screenshots

Expected Versus Actual Behavior

No response

KeePassXC Debug Information

Firefox add-on version 1.9.6, Firefox 134, Windows 11

Operating System

Windows

Linux Desktop Environment

None

Linux Windowing System

None

@droidmonkey droidmonkey transferred this issue from keepassxreboot/keepassxc Jan 27, 2025
@varjolintu
Copy link
Member

Can you share the HTML code of the input field where the icon is shown?

@ygoe
Copy link
Author

ygoe commented Jan 27, 2025

I copied this out of Firefox' devtools inspector. There's JavaScript code involved that creates the form field styles. So here's the result that's rendered:

<div class="form-row require-minitab" data-column-widths="* auto" style="grid-template-columns: 1fr max-content;">
	<div class="label">Speicherdauer</div>
	<input type="text" name="retentionPeriod">
	<div></div>

	<div class="label" disabled=""></div>
	<label disabled=""><input type="checkbox" name="hasMinMaxValues" disabled="" class="ff-checkbox"><span class="ff-checkbox" title=""></span> Hat Min-/Max-Werte</label>
	<div></div>
</div>

@varjolintu
Copy link
Member

I have no idea where that icon comes. Using that HTML code even along username and password inputs doesn't show the TOTP icon for me.

@ygoe
Copy link
Author

ygoe commented Jan 28, 2025

It doesn't appear every time it seems. It does for a while but then doesn't anymore. Other pages also trigger the password phase, so maybe Keepass finds a username and password field first (which do exist on another page of the app for something completely different) and as I'm browsing around it later thinks it sees a 2FA form and does that. But then it always happens at exactly this spot. When I'm scrolling through that page the grey/green balloon even closely follows that checkbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants