Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your plugin isn't upgraded to work with cordova 3.0.0 #2

Open
prodanac opened this issue Oct 22, 2013 · 5 comments
Open

Your plugin isn't upgraded to work with cordova 3.0.0 #2

prodanac opened this issue Oct 22, 2013 · 5 comments

Comments

@prodanac
Copy link

Are you planning on upgrading it any time soon? I need it and I'm just asking.

@jcroucher
Copy link

Hello,

I have updated it for Cordova 3.0 at https://github.com/jcroucher/cordova-phonegap-audio-encode

@prodanac
Copy link
Author

prodanac commented Nov 4, 2013

Thanks for the effort and notification.

On Mon, Nov 4, 2013 at 7:50 AM, John Croucher [email protected]:

Hello,

I have updated it for Cordova 3.0 at
https://github.com/jcroucher/cordova-phonegap-audio-encode


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-27665566
.

@gitdisrupt
Copy link

Here we are, a couple of years later! This is a great plugin, however there are 2 issues ... would love it if anyone is feeling ambitious enough to fix?

  1. the callbacks in JS never fire
  2. not compatible with cordova 4.0.

@jcroucher
Copy link

I wonder what they have broken this time.

What errors are you getting when running it with Cordova 4.0?

@gitdisrupt
Copy link

I was not getting any errors, it was just that the callbacks were not firing in JS ...

After several hours banging my head against a wall, i was finally able to solve this on my own by referencing newer plugins, although, it would be great if you want to double check my work, i am by no means an expert in C ...

Below is what i needed to change (i am going to attach screen caps because i am short on time today, i hope thats cool):

In the file: AudioEncode.h
UPDATE: im realizing the additional import was not necessary ... see image attached
1

In the file: AudioEncode.m
2

I hope this helps... I have not forked your plugin as i have not had ample time to test this yet, but at first glance, the plugin appears to be working with these changes in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants