Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro-datasets: Investigate spark.SparkHiveDataset flaky unit tests #755

Open
ankatiyar opened this issue Jul 8, 2024 · 3 comments
Open

Comments

@ankatiyar
Copy link
Contributor

ankatiyar commented Jul 8, 2024

Description

The tests for spark.SparkHiveDataset have been failing intermittently during nightly builds and checks for PRs. Usually re-running them solves the problem but we should investigate the root cause.

Context

Eg for a failed run - https://github.com/kedro-org/kedro-plugins/actions/runs/9807280152/job/27080744636
Seems to be related to the SparkSession setup.

@felipemonroy
Copy link
Contributor

Hi @ankatiyar , I have opened a PR with a possible solution. Could you check it please?. I am not sure on how to re-run the actions to test it again.

@felipemonroy
Copy link
Contributor

I am not sure how to fix it. I assume some tests use an unintended spark session (like the ones in test_spark_hive_dataset using one without hive support). Do we have the option of running tests/spark without xdist as the ones in tests/tensorflow/test_tensorflow_model_dataset.py?

@ankatiyar
Copy link
Contributor Author

ankatiyar commented Jul 22, 2024

@felipemonroy we can investigate this at our end, if in the meantime your tests are failing on other PRs with this error, tag someone from the team (or me) we can re-run the tests for the PR. Locally, you can run make test-no-spark I think to run all the other unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants