Redundant request when the limit is more than the nearest multiple of hundred from the total_count

[akindemirci]

In AbstractApi.php, the function retrieveData makes a redundant final request if the limit is defined over 200.

On line 357, the if statement to reset $limit to zero and end the while loop is currently like this:

$newDataSet['offset'] >= $newDataSet['total_count']

This way, the while loop continues for another request whose result will be definitely empty.

I think it should be like this:

$newDataSet['limit'] + $newDataSet['offset'] >= $newDataSet['total_count']

Thanks.

[Art4]

Thank you for filing this issue. I've created a test in #440, but cannot reproduce it. Could you please take a look at the test code or could you precise the circumstances of this issue? Thank you.

[akindemirci]

Thanks for looking into this issue.

I realized that the condition I wrote the first time for the issue was not exactly true. The precise condition is this:

• When the limit is more than the nearest multiple of hundred from the total_count (including itself), the issue arises.

No issue when: total_count = 250; limit = 300
The issue exists when: total_count = 250; limit = 301
(limit is more than the nearest multiple of hundred from 250 which is 300)

No issue when: total_count = 100; limit = 100
The issue exists when: total_count = 100; limit = 101
(limit is more than the nearest multiple of hundred from 100 (including itself) which is 100)

It should make one request if the total_count is 100, even if the limit is defined more than this.