Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting TXs with incomplete keys must produce easily understandable error #452

Open
coderofstuff opened this issue Apr 11, 2024 · 2 comments · Fixed by #479
Open

Submitting TXs with incomplete keys must produce easily understandable error #452

coderofstuff opened this issue Apr 11, 2024 · 2 comments · Fixed by #479
Labels
bug Something isn't working

Comments

@coderofstuff
Copy link
Collaborator

coderofstuff commented Apr 11, 2024

Describe the bug
When submitting a transaction where not all inputs are signed, the script engine produces a cryptic error that's not easily linkable to missing signatures in the signed transaction.

To Reproduce
Steps to reproduce the behavior:

  1. Sign a tx but skip some needed keys
  2. Submit the tx to the node
  3. Get the error something like stack needs 1 but has 0

Expected behavior

  1. If there are unsigned inputs, either the submit or the script engine should yield a comprehensive error that allows the developer to figure out what the error actually is
@coderofstuff coderofstuff added the bug Something isn't working label Apr 11, 2024
@coderofstuff coderofstuff changed the title Signing with incomplete keys must produce easily understandable error Submitting TXs with incomplete keys must produce easily understandable error Apr 11, 2024
@IzioDev
Copy link
Contributor

IzioDev commented Aug 29, 2024

can be closed

@D-Stacks
Copy link
Collaborator

can be closed

it should auto-close when the new release comes out. currently fix is still only on the dev branch, as far as i can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants