Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make binding controller don't need to update work when there's no content changes. #6017

Closed
zach593 opened this issue Jan 5, 2025 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@zach593
Copy link
Contributor

zach593 commented Jan 5, 2025

What would you like to be added:

Make binding controller don't need to update work when there's no content changes.

It contains two part:

  1. Fixed an issue where deepequal checks would directly compare byte slices, which caused the check to always return false, tracked in deepequal check in helper.CreateOrUpdateWork() always return false, because resource.MarshalJSON() will add \n at the end of JSON #5938
  2. Copy karmada-webhook's mutating work logic to helper.CreateOrUpdateWork() so deepequal can return true when no actual content has changed.

Why is this needed:

When binding controllers, this can help reduce the update requests to the kube-apiserver, thus speeding up controller processing.

It might be possible to add similar logic to the execution controller and the job status controller, but the member cluster webhooks would be a very difficult hurdle to overcome, and I think we can discuss how to deal with it later.

I needed a place to discuss and track related PRs, so I created this issue. Please notify me if this is a misuse.

@RainbowMango
Copy link
Member

RainbowMango commented Jan 10, 2025

/close
Let's track all of these things at #6031

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closing this issue.

In response to this:

/close
Let's track all of these things at #6013

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zach593
Copy link
Contributor Author

zach593 commented Jan 10, 2025

@RainbowMango referenced wrong issue? #6013 is a PR of "expose metrics of karmada-metrics-adapter"

@RainbowMango
Copy link
Member

Yeah, thanks for the reminder. it's #6031.
Updated on above as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

3 participants