You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy karmada-webhook's mutating work logic to helper.CreateOrUpdateWork() so deepequal can return true when no actual content has changed.
Why is this needed:
When binding controllers, this can help reduce the update requests to the kube-apiserver, thus speeding up controller processing.
It might be possible to add similar logic to the execution controller and the job status controller, but the member cluster webhooks would be a very difficult hurdle to overcome, and I think we can discuss how to deal with it later.
I needed a place to discuss and track related PRs, so I created this issue. Please notify me if this is a misuse.
The text was updated successfully, but these errors were encountered:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
What would you like to be added:
Make binding controller don't need to update work when there's no content changes.
It contains two part:
helper.CreateOrUpdateWork()
so deepequal can return true when no actual content has changed.Why is this needed:
When binding controllers, this can help reduce the update requests to the kube-apiserver, thus speeding up controller processing.
It might be possible to add similar logic to the execution controller and the job status controller, but the member cluster webhooks would be a very difficult hurdle to overcome, and I think we can discuss how to deal with it later.
I needed a place to discuss and track related PRs, so I created this issue. Please notify me if this is a misuse.
The text was updated successfully, but these errors were encountered: