Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there are not enough resources when promoting, the scheduler can not work #5697

Open
spiritNO1 opened this issue Oct 15, 2024 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@spiritNO1
Copy link
Contributor

When promoting, the scheduler should calculate the member cluster, this requires sufficient resources to be available when calculating scheduling. Since the member cluster already has the corresponding workload, the scheduler should skip the calculation process and write the result directly to rb.

@spiritNO1 spiritNO1 added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2024
@chaosi-zju
Copy link
Member

Judging from the scheduling logic, there seems to be a problem. May I ask whether you measured it in the actual test or inferred it?

@spiritNO1
Copy link
Contributor Author

Judging from the scheduling logic, there seems to be a problem. May I ask whether you measured it in the actual test or inferred it?

We referred to this part of the logic to automatically create pp of member cluster workloads, but found that some workloads could not create work because there was no scheduling result.
image
We did not use the promote command directly, but the logic is the same.
We observed the following error in log.
image
I think if promoting, we should directly patch the schedule result to rb and not need to caculate.

@RainbowMango RainbowMango added this to the v1.12 milestone Oct 15, 2024
@chaosi-zju
Copy link
Member

I think if promoting, we should directly patch the schedule result to rb and not need to caculate.

How does the scheduler identify whether this is promote or normal scheduling

@spiritNO1
Copy link
Contributor Author

I think if promoting, we should directly patch the schedule result to rb and not need to caculate.

How does the scheduler identify whether this is promote or normal scheduling

Maybe use an annotation or a label, delete it after scheduling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: No status
Development

No branches or pull requests

3 participants