Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator/pkg/controlplane/etcd: remove redundant EtcdPeerServiceName #5592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

operator/pkg/controlplane/etcd: remove redundant EtcdPeerServiceName #5592

wants to merge 1 commit into from

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we remove the redundant field EtcdPeerServiceName in the function installKarmadaEtcd in operator/pkg/controlplane/etcd package.

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:
Fixes #5584

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lonelycz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2024
@mohamedawnallah
Copy link
Contributor Author

cc: @zhzhuang-zju

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.37%. Comparing base (53c00f7) to head (93b95c3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5592      +/-   ##
==========================================
- Coverage   41.38%   41.37%   -0.01%     
==========================================
  Files         651      651              
  Lines       55259    55258       -1     
==========================================
- Hits        22867    22863       -4     
- Misses      30913    30915       +2     
- Partials     1479     1480       +1
Flag Coverage Δ
unittests 41.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah force-pushed the removeEtcdPeerServiceNameRedundantField branch from 004d1a5 to b04f90a Compare September 23, 2024 09:27
@zhzhuang-zju
Copy link
Contributor

@mohamedawnallah Could you please re-submit once to trigger the CI Test on Kubernetes, which is used to verify the functionality of the karmada-operator?

@mohamedawnallah mohamedawnallah force-pushed the removeEtcdPeerServiceNameRedundantField branch from b04f90a to 93b95c3 Compare October 25, 2024 07:21
@zhzhuang-zju
Copy link
Contributor

/lgtm
thanks, cc @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvin0327 calvin0327 Awaiting requested review from calvin0327

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

@zhzhuang-zju zhzhuang-zju Awaiting requested review from zhzhuang-zju

Assignees

@zhzhuang-zju zhzhuang-zju

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is EtcdPeerServiceName field in installKarmadaEtcd redundant in operator/pkg/controlplane/etcd?
4 participants
@mohamedawnallah @karmada-bot @codecov-commenter @zhzhuang-zju