Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearAnalysis is not work now #9

Open
some2112 opened this issue Dec 1, 2023 · 4 comments
Open

clearAnalysis is not work now #9

some2112 opened this issue Dec 1, 2023 · 4 comments

Comments

@some2112
Copy link

some2112 commented Dec 1, 2023

 MENU
  final JMenuItem clearAnalysis =
    new JMenuItem(resourceBundle.getString("Menu.analyze.clearAnalysis"));
clearAnalysis.addActionListener(
    new ActionListener() {
      @Override
      public void actionPerformed(ActionEvent e) {
        Lizzie.board.clearAnalysis();
      }
    });
analyzeMenu.add(clearAnalysis);

Board
  public void clearAnalysis() {
getData().tryToClearBestMoves();

}

BoardData
public void tryToClearBestMoves() {
bestMoves = new ArrayList<>();
playouts = 0;
engineIndex = Leelaz.engineIndex;
komi = Lizzie.board.getHistory().getGameInfo().getKomi();
if (Lizzie.leelaz.isKataGo) {
  Lizzie.leelaz.scoreMean = 0;
  Lizzie.leelaz.scoreStdev = 0;
}

}

@some2112
Copy link
Author

some2112 commented Dec 1, 2023

clearThisLizzieBestmoves is the function I want to implement most

https://github.com/yzyray/lizzieyzy/blob/main/src/main/java/featurecat/lizzie/gui/Menu.java

@kaorahi
Copy link
Owner

kaorahi commented Dec 2, 2023

If you are reporting a bug, could you please provide a detailed description including (1) the actions you took, (2) the results you received, and (3) the expected outcome?

@some2112
Copy link
Author

some2112 commented Dec 3, 2023

image
is a bug
Nothing happens after pressing

@kaorahi
Copy link
Owner

kaorahi commented Dec 5, 2023

It still remains uncertain to me what behavior you expect from this menu. Here is its intended usage. Does this make sense to you?

From 31d5ff3:

Added a clear analysis menu option for, when you switch engines, you dont get to see the results of analysis until the playout counter reaches the level of the previous engine; clearAnalysis fixes that by clearing the playouts of previous engine for current move.

If you didn't experience such situations, you can simply ignore and forget this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants