Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: RBAC: Implement RBAC tests #767

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

BE: RBAC: Implement RBAC tests #767

wants to merge 6 commits into from
+1,172 −1

Conversation

zambrinf
Copy link

@zambrinf zambrinf commented Jan 12, 2025 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Added tests to cober AccessControlService
Closes #729

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/rbac Related to Role Based Access Control feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 12, 2025
github-actions[bot]
github-actions bot reviewed Jan 12, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi zambrinf! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@zambrinf zambrinf marked this pull request as ready for review January 12, 2025 14:39
@zambrinf zambrinf requested a review from a team as a code owner January 12, 2025 14:39
@Haarolean Haarolean added scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Jan 12, 2025
@Haarolean Haarolean changed the title Issues/729: Implement RBAC tests BE: RBAC: Implement RBAC tests Jan 12, 2025
@Haarolean
Copy link
Member

@zambrinf could we please add some tests to cover these cases?

If the tests fail due to faulty business logic, we can disable them until the issues are resolved.

@zambrinf
Copy link
Author

zambrinf commented Jan 14, 2025 •
edited
Loading

@Haarolean Done. I added a test class RbacEditTopicTest specific to #260 but I couldn't reproduce a RBAC error. And the test for #461 is disabled because it's failing.

@Haarolean Haarolean self-requested a review January 14, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Haarolean Haarolean Awaiting requested review from Haarolean

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/rbac Related to Role Based Access Control feature scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BE: RBAC: Implement RBAC tests
2 participants
@zambrinf @Haarolean