Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: RBAC: Implement RBAC tests #729

Open
Haarolean opened this issue Dec 28, 2024 · 3 comments · May be fixed by #767
Open

BE: RBAC: Implement RBAC tests #729

Haarolean opened this issue Dec 28, 2024 · 3 comments · May be fixed by #767
Assignees
@zambrinf
Labels
area/rbac Related to Role Based Access Control feature good first issue Up for grabs scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt

Comments

@Haarolean
Copy link
Member

Cover AccessControlService with tests, mock anything unrelated (extractors, auth parts, etc)
@Haarolean Haarolean added good first issue Up for grabs scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt area/rbac Related to Role Based Access Control feature labels Dec 28, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 28, 2024
@Haarolean Haarolean moved this to Todo in Up for grabs Dec 28, 2024
@Haarolean Haarolean mentioned this issue Dec 28, 2024
Merged
13 tasks
@Haarolean Haarolean modified the milestone: 1.2 Dec 31, 2024
@zambrinf
Copy link

working on this

@zambrinf
Copy link

zambrinf commented Jan 12, 2025 •
edited
Loading

@Haarolean there is something wrong with PNPM build. When I try to build the project it fails. Also it's failing your github actions E2E PR smoke tests for most of the PRs. As a workaround I commented out the frontend-maven-plugin plugin from contract/pom.xml

Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:pnpm (pnpm build) on project api: Failed to run task: 'pnpm build' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 2 (Exit value: 2) -> [Help 1]

@Haarolean
Copy link
Member Author

@Haarolean there is something wrong with PNPM build. When I try to build the project it fails. Also it's failing your github actions E2E PR smoke tests for most of the PRs. As a workaround I commented out the frontend-maven-plugin plugin from contract/pom.xml

Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:pnpm (pnpm build) on project api: Failed to run task: 'pnpm build' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 2 (Exit value: 2) -> [Help 1]

  1. your build is failing perhaps due to missing npm or something. You can build with local profile instead locally.
  2. We're aware of the flaky e2e test

@Haarolean Haarolean removed the status in Up for grabs Jan 12, 2025
@Haarolean Haarolean moved this to In Development in Up for grabs Jan 12, 2025
zambrinf added a commit to zambrinf/kafka-ui that referenced this issue Jan 12, 2025
@zambrinf
added more test, closes kafbat#729
f4098a1
zambrinf added a commit to zambrinf/kafka-ui that referenced this issue Jan 12, 2025
@zambrinf
added more test, closes kafbat#729
1d5ca3b
@zambrinf zambrinf linked a pull request Jan 12, 2025 that will close this issue
Open
13 tasks
@Haarolean Haarolean moved this from In Development to In Review in Up for grabs Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zambrinf zambrinf

Labels
area/rbac Related to Role Based Access Control feature good first issue Up for grabs scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
Up for grabs
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BE: RBAC: Implement RBAC tests zambrinf/kafka-ui
2 participants
@Haarolean @zambrinf