From 97e9201d0609d2f3ae7f23a68b4893f5961f2113 Mon Sep 17 00:00:00 2001 From: ormergi <43184538+ormergi@users.noreply.github.com> Date: Sun, 10 May 2020 14:03:21 +0300 Subject: [PATCH] Remove Pending flag from skipped tests (#138) Removing Pending flag from 2162 regarding issue resolved [1] and 2165 regarding issue resolved [2]. Those tests were flaky due to an issue with how the manager pods reported readiness, this caused the manager-pods to raise "..connection refused" errors right after deletion. Now that [3] is merged we can continue to use these tests. [1] https://github.com/k8snetworkplumbingwg/kubemacpool/issues/104 [2] https://github.com/k8snetworkplumbingwg/kubemacpool/issues/105 [3] https://github.com/k8snetworkplumbingwg/kubemacpool/pull/124 Signed-off-by: Or Mergi --- tests/virtual_machines_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/virtual_machines_test.go b/tests/virtual_machines_test.go index bf3948659..ea2b1ce54 100644 --- a/tests/virtual_machines_test.go +++ b/tests/virtual_machines_test.go @@ -266,8 +266,8 @@ var _ = Describe("Virtual Machines", func() { Expect(err).ToNot(HaveOccurred()) }) }) - //2162 test postponed due to issue: https://github.com/k8snetworkplumbingwg/kubemacpool/issues/104 - PContext("When trying to create a VM after all MAC addresses in range have been occupied", func() { + //2162 + Context("When trying to create a VM after all MAC addresses in range have been occupied", func() { It("should return an error because no MAC address is available", func() { err := initKubemacpoolParams("02:00:00:00:00:00", "02:00:00:00:00:01") Expect(err).ToNot(HaveOccurred()) @@ -289,8 +289,8 @@ var _ = Describe("Virtual Machines", func() { Expect(err).To(HaveOccurred()) }) }) - //2165 test postponed due to issue: https://github.com/k8snetworkplumbingwg/kubemacpool/issues/105 - PContext("when trying to create a VM after a MAC address has just been released duo to a VM deletion", func() { + //2165 + Context("when trying to create a VM after a MAC address has just been released duo to a VM deletion", func() { It("should re-use the released MAC address for the creation of the new VM and not return an error", func() { err := initKubemacpoolParams("02:00:00:00:00:00", "02:00:00:00:00:02") Expect(err).ToNot(HaveOccurred())