Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logging on KafkaTopic write errors #3

Open
amajedi opened this issue Nov 26, 2018 · 1 comment
Open

Debug logging on KafkaTopic write errors #3

amajedi opened this issue Nov 26, 2018 · 1 comment

Comments

@amajedi
Copy link
Contributor

amajedi commented Nov 26, 2018

It would be helpful if the message offset and some additional metadata was logged as a result of write exceptions raised doing writes to kafka topics.

Writes are handled asynchronously in KafkaTopic.flush()

A situation I ran into was when attempting to write a large message, one which exceeded the output topic's message size limit. This caused the write to fail, but there was not enough information logged to debug the problematic message.

I suggest at minimum logging the primary key associated with the output message, in addition to the exception logging already in place.

@amajedi amajedi changed the title Offset debug logging on output topic write errors Debug logging on output topic write errors Nov 26, 2018
@amajedi amajedi changed the title Debug logging on output topic write errors Debug logging on KafkaTopic write errors Nov 26, 2018
@moritastic
Copy link
Collaborator

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants