Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CLI options for make_http_index? #229

Open
billiegoose opened this issue Apr 25, 2018 · 4 comments
Open

More CLI options for make_http_index? #229

billiegoose opened this issue Apr 25, 2018 · 4 comments

Comments

@billiegoose
Copy link
Contributor

@jvilk I ran into an issue where this line in /scripts/make_http_index.ts:

// ignore non-essential directories / files
if (ignoreFiles.indexOf(file) !== -1 || file[0] === '.') {
  return;
}

forced me to fork your script. I needed to include hidden filenames (like .eslintrc) in my index. My question for you is: should I continue using my fork (and possibly publish it) or would you be receptive to PRs adding more bells and whistles to this script?

@billiegoose
Copy link
Contributor Author

I would probably start by adding support for passing in globs, and writing the result to stdout.

@jvilk
Copy link
Owner

jvilk commented Apr 26, 2018

Would it be acceptable to add a --include-hidden-files switch? That would be simplest to add.

@billiegoose
Copy link
Contributor Author

I could live with that. 😀

@james-pre
Copy link
Collaborator

Please use zen-fs/core#16

@james-pre james-pre closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Repository owner locked and limited conversation to collaborators Oct 25, 2023
Repository owner unlocked this conversation May 17, 2024
@james-pre james-pre reopened this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants