Incorrect unmatch API

[mhluska]

It seems like the tinder_client.remove call expects a match ID not a user ID. This problem might exist in other areas of the API. I got stuck on this for a while. It would be good to rename it.

Another issue is that if the tinder_client.remove call returns {status: 400} because of passing in a user ID, the gem doesn't raise an error.

Another issue, but this is personal preference, is the naming of the method. Why not just call it unmatch?

[jvenezia]

Hi @mhluska

At the time I wrote it, tinder_client.remove was to remove a previous "like" or "dislike" you made.
A match is different, it's when two people like each other. So if this exists, it's not yet implemented in this gem.

The gem uses an unofficial API, so it can break at any time...
If you confirm that the remove feature does not work anymore, then we should get rid of it in the gem.
If you confirm that unmatchworks well, then we should add this feature :)

Pull-requests are appreciated!

[mhluska]

Ah I see. Yeah, I've confirmed that remove works for unmatching by passing a match ID. I'll see if I can send a PR later this week.

[jvenezia]

So renaming it unmatch and passing a match_id seems ok to me :)