Should we update stylelint-config-pie's usage of import/extensions
#2002
ashleynolan
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
As part of a recent PR, I had to work around one of our ESLint config rules – import/extensions – which relates to whether the
.js
extension is defined on imports in the codebase.Currently, at the root of the PIE repo, we turn this rule off (which allows both the use of
.js
or no extension in imports), but I had to ignore this rule for our stylelint config package, as it defines it's owneslintrc
currently, which is why I had to manually ignore it in my PR.So the main question is – if we're turning the rule off for all of our components (as well as needing to disable it in some of our other tools), should we just turn it off in our shared ESLint config?
The main thing I'd be unsure about would be – do we think this would be a good idea for CW, where this rule is set to false currently and so file extensions are forced off. I think I'm ok with that, as CW will get more access to using native ESM when updating to Node 20 and Next 14 in the future, and so we might want to just get ahead of it – but it would be good to hear people's thoughts!
Beta Was this translation helpful? Give feedback.
All reactions