Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Samples Aspire AppHost Project #1543

Open
slang25 opened this issue Oct 16, 2024 · 3 comments
Open

Add Samples Aspire AppHost Project #1543

slang25 opened this issue Oct 16, 2024 · 3 comments
Assignees

Comments

@slang25
Copy link
Member

slang25 commented Oct 16, 2024

Add an Aspire AppHost project (using Aspire 9 RC1), which:

  • starts up both samples app projects
  • adds the AWSSDK OTEL instrumentation
  • adds the ASP.NET Core instrumentation
  • adds a LocalStack docker container (something like this)
@martincostello
Copy link
Member

Doing this will probably end up doing #874 too (or at least make it easier to do).

@slang25
Copy link
Member Author

slang25 commented Oct 16, 2024

Doing this will probably end up doing #874 too (or at least make it easier to do).

easier to do for sure. To go back to our conversation, for SNS → SQS distributed tracing, we'd need to do some custom propagation to make it work. AWS Messaging do this: https://github.com/awslabs/aws-dotnet-messaging/tree/main/src/AWS.Messaging.Telemetry.OpenTelemetry

@martincostello
Copy link
Member

Without looking too closely, looks like that could just be referenced and dropped in and it would Just Work™️. It just looks like OTel glue that isn't specifically tied to their messaging framework (unless that is adding some extra context to the traces).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants