-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicate counter identity rules #13
Comments
neongreen
changed the title
Remove counters when rules are reloaded, or explain why we don't need to do anything
Removing counters when rules are reloaded
Sep 27, 2019
neongreen
changed the title
Removing counters when rules are reloaded
Replicate counter identity logic
Sep 27, 2019
neongreen
changed the title
Replicate counter identity logic
Replicate counter identity rules
Sep 27, 2019
mdimjasevic
pushed a commit
that referenced
this issue
Oct 8, 2019
mdimjasevic
pushed a commit
that referenced
this issue
Oct 11, 2019
mdimjasevic
pushed a commit
that referenced
this issue
Oct 14, 2019
mdimjasevic
pushed a commit
that referenced
this issue
Oct 15, 2019
mdimjasevic
added a commit
that referenced
this issue
Oct 15, 2019
* Closes #13: replicates the rule counter logic from lyft/ratelimit with regard to rule reloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like we do not need to remove counters when rules are reloaded. The behavior of lyft/ratelimit is as follows:
So we need to:
CounterKey
The text was updated successfully, but these errors were encountered: