Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX User private info exposed #303

Open
tyagishuchi1 opened this issue Jul 20, 2020 · 1 comment
Open

FIX User private info exposed #303

tyagishuchi1 opened this issue Jul 20, 2020 · 1 comment
Assignees
Labels
bug Highest priority production Needs to be addressed in production
Milestone

Comments

@tyagishuchi1
Copy link

tyagishuchi1 commented Jul 20, 2020

  1. Any user's private profile info can be accessed publicly via anybody as long as the wallet address is known. And since the Smart contract's addresses are public and the Oath Keeper/Advocate openly mentions the list of wallets, addresses can be very easily accessed. Although all APIs expose data publicly, but with this API a wallet address can be attached to a user's real world identity.
  2. It also exposes the id related to the user which makes the JBP DB too predictable for resource harvesting.
    image

Expected Behavior

The API should only return the info if the user is authorized

Possible Solution

Steps to Reproduce

Environment: Beta/Test/Temp

  1. Send a GET request to https://beta.jur.io/api/v1/user providing wallet as a header
@tyagishuchi1 tyagishuchi1 added bug Highest priority production Needs to be addressed in production labels Jul 20, 2020
@tyagishuchi1 tyagishuchi1 added this to the Legacy milestone Jul 20, 2020
@mtmsuhail
Copy link

mtmsuhail commented Jul 22, 2020

@tyagishuchi1 This issue reported earlier, this also an issue with many other end-points

Ex:-

  1. Send a DELETE request to https://beta.jur.io/api/v1/user providing wallet as a header
  2. Send a PUT request to https://beta.jur.io/api/v1/user providing wallet as a header with body content

Solution: We should authenticate the wallet using some methods like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Highest priority production Needs to be addressed in production
Projects
None yet
Development

No branches or pull requests

4 participants