Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling service does not exit with non-zero code at error #211

Open
tyagishuchi1 opened this issue Jun 25, 2020 · 1 comment
Open

Polling service does not exit with non-zero code at error #211

tyagishuchi1 opened this issue Jun 25, 2020 · 1 comment
Labels
bug Highest priority
Milestone

Comments

@tyagishuchi1
Copy link

image

image

Polling service does not catch the error and hence get's stuck at one block with the above error message.

Expected Behavior

It should catch the error and exit the process with a non-zero code.

Steps to Reproduce

  1. Run thor test node on the local machine.
    bin/thor --network test --api-timeout 10
  2. Connect it to the polling service by adding it's URL in the .env.polling file in the root folder.
  3. Run the service.
    socker-compose up -d polling_rtr
  4. Stop the thor node.
@tyagishuchi1 tyagishuchi1 added the bug Highest priority label Jun 25, 2020
@tyagishuchi1 tyagishuchi1 added this to the Status milestone Jun 25, 2020
@ashishjur
Copy link

ashishjur commented Jul 17, 2020

We weren't able to reproduce unhandled promise error reliably. With current fix of using node flag, it behaves as expected. I think we should close this.

I'm removing myself from this. If any input is needed from me, please assign/tag.

@ashishjur ashishjur removed their assignment Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Highest priority
Projects
None yet
Development

No branches or pull requests

2 participants