Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error info when attempting to use an unavailable formatter #362

Open
minrk opened this issue Sep 5, 2024 · 0 comments
Open

No error info when attempting to use an unavailable formatter #362

minrk opened this issue Sep 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@minrk
Copy link

minrk commented Sep 5, 2024

Description

When a formatter is unavailable, POST /format fails with 404 here, but the error isn't shown to the user, instead it shows this:

Screenshot 2024-09-05 at 09 32 58

Reproduce

  1. add a nonexistent formatter, e.g. "asdf" in jupyterlab settings
  2. invoke formatter
  3. see error

Expected behavior

I'd expect the error message to be shown, which would help point the way to what's wrong in my configuration.
Presumably need to handle the error format here.

On the server side, I'd recommend sending a JSON error response, rather than a plain-text one. That should be easier for clients to handle consistently.

Context

  • jupyterlab 4.2.4
  • jupyterlab_code_formatter 3.0.2
@minrk minrk added the bug Something isn't working label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant