Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --dashboards-dir flag to deploy.py accept multiple values #109

Open
consideRatio opened this issue Apr 7, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@consideRatio
Copy link
Member

consideRatio commented Apr 7, 2024

I'd like to be able to specify multiple --dashboards-dir to deploy both dashboards and global-dashboards folders in one deploy.py CLI call.

Related code can be found below, where I think we can allow for the same flag to be specified multiple times like helm install --values a.yaml --values b.yaml is possible for example. I believe argparse can help us here as well. Maybe action="append" or something like that if I recall correctly.

    parser.add_argument(
        '--dashboards-dir',
        default="dashboards",
        help='Directory of jsonnet dashboards to deploy',
    )

    # ...

    for dashboard in glob(f'{args.dashboards_dir}/*.jsonnet'):
@consideRatio consideRatio added the enhancement New feature or request label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant