Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterCAD icon should be highlighted in the file browser when the file is selected #484

Closed
SylvainCorlay opened this issue Oct 16, 2024 · 3 comments · Fixed by #520
Closed
Milestone

Comments

@SylvainCorlay
Copy link
Member

I presume this would be achieved by adding the right CSS classes to the SVG files.

Screenshots below show the change os style of the selected file with a JCAD file vs a notebook.

Image Image

@SylvainCorlay SylvainCorlay added this to the 3.0.0 milestone Oct 16, 2024
@SylvainCorlay
Copy link
Member Author

Related to jupytercad/JupyterCAD-FreeCAD#14.

@martinRenou
Copy link
Member

We may not need to take any action on this if we change the design of the logo and the new logo fits nicer with the blue background.

Let's see if we need to take any action once that new logo is settled.

@SylvainCorlay
Copy link
Member Author

We may not need to take any action on this if we change the design of the logo and the new logo fits nicer with the blue background.

It makes sense to wait for the new logo. Although even with the new logo, we should probably apply the selected style like for all other core Jupyter file types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants