Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both fatih/color and defined consts for shell colors? #34

Open
andres-lowrie opened this issue Sep 9, 2018 · 1 comment
Open

Both fatih/color and defined consts for shell colors? #34

andres-lowrie opened this issue Sep 9, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@andres-lowrie
Copy link

Hello

Was curious as to why you're using both the fatih/color package and the escape characters defined in the util package

https://github.com/DrakeW/corgi/blob/develop/util/util.go#L23

For example in this file they're both being used:

const values here
https://github.com/DrakeW/corgi/blob/develop/snippet/step.go#L62

and the color package here
https://github.com/DrakeW/corgi/blob/develop/snippet/step.go#L96

I can create a Pull request consolidating the usage to the fatih/color package but before doing so I wanted to check to see if there was something I'm missing in terms of a need for both of them

@junyu-w
Copy link
Owner

junyu-w commented Sep 13, 2018

hi @andres-lowrie , the escape chars are only used for exporting to shell script, if you can make them consistent by using the color package and keep output color printed when executing the exported shell script, please go ahead and open a PR!

@junyu-w junyu-w added the help wanted Extra attention is needed label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants