Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ResourceLockProvider's methods to be in sync with DisplayNameGenerator #4163

Closed
1 task
marcphilipp opened this issue Nov 29, 2024 · 0 comments · Fixed by #4267
Closed
1 task

Change ResourceLockProvider's methods to be in sync with DisplayNameGenerator #4163

marcphilipp opened this issue Nov 29, 2024 · 0 comments · Fixed by #4267
Assignees
@marcphilipp
Labels
component: Jupiter theme: extensions type: task
Milestone
5.12.0-M1

Comments

@marcphilipp
Copy link
Member

As outlined in #4130 (comment), DisplayNameGenerator is receiving new methods with an additional List<Class<?>> enclosingInstanceTypes parameter. Once that issue is resolved, we should change ResourceLockProvider accordingly. Since it's not yet released, we don't have to make it backward compatible, though.

Deliverables

  • Add List<Class<?>> enclosingInstanceTypes parameter to provideForNestedClass and provideForMethod methods
@marcphilipp marcphilipp added this to the 5.12 M1 milestone Nov 29, 2024
marcphilipp added a commit that referenced this issue Jan 25, 2025
@marcphilipp
Provide runtime enclosing instance types to ResourceLocksProviders
82d8cc9 
Resolves #4163.
@marcphilipp marcphilipp mentioned this issue Jan 25, 2025
Merged
6 tasks
@marcphilipp marcphilipp self-assigned this Jan 25, 2025
marcphilipp added a commit that referenced this issue Jan 26, 2025
@marcphilipp
Provide runtime enclosing instance types to ResourceLocksProviders
3f34c8d 
Resolves #4163.
marcphilipp added a commit that referenced this issue Jan 26, 2025
@marcphilipp @sbrannen
Provide runtime enclosing instance types to ResourceLocksProviders
511ab7d 
Make API consistent with `DisplayNameGenerator` prior to releasing it in
5.12.

Resolves #4163.

---------

Co-authored-by: Sam Brannen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcphilipp marcphilipp

Labels
component: Jupiter theme: extensions type: task
Projects
None yet
Milestone
5.12.0-M1
Development

Successfully merging a pull request may close this issue.

Provide runtime enclosing instance types to ResourceLocksProviders junit-team/junit5
2 participants
@sbrannen @marcphilipp