Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TerminationStatus when SolutionLimit is 1 #62

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

odow
Copy link
Member

@odow odow commented Feb 8, 2024

Closes #61

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cc387e) 97.45% compared to head (8489974) 97.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   97.45%   97.47%   +0.02%     
==========================================
  Files           3        3              
  Lines         471      475       +4     
==========================================
+ Hits          459      463       +4     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chriscoey
Copy link
Contributor

Thanks @odow!! Please tag after merge 😃

@odow odow merged commit 7161b6f into master Feb 8, 2024
7 checks passed
@odow odow deleted the od/solution-limit branch February 8, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

When SolutionLimit is 1 but there exist multiple solutions, status should be SOLUTION_LIMIT, not OPTIMAL
2 participants