Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First constraint index to 1 instead of 2 #523

Merged
merged 2 commits into from
Oct 20, 2023
Merged

First constraint index to 1 instead of 2 #523

merged 2 commits into from
Oct 20, 2023

Conversation

blegat
Copy link
Member

@blegat blegat commented Oct 19, 2023

Closes #522

@blegat blegat mentioned this pull request Oct 19, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b42b4c4) 90.88% compared to head (1a2fe42) 90.88%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files           5        5           
  Lines        2425     2425           
=======================================
  Hits         2204     2204           
  Misses        221      221
Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 89.97% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

odow
odow approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small test

@blegat blegat merged commit 3835e89 into master Oct 20, 2023
4 checks passed
@blegat blegat deleted the bl/last_con_idx branch October 20, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odow odow odow approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConstraintIndex starts from 2
2 participants
@blegat @odow