Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2D conv #376

Open
ericphanson opened this issue Mar 9, 2020 · 1 comment · May be fixed by #635
Open

Add 2D conv #376

ericphanson opened this issue Mar 9, 2020 · 1 comment · May be fixed by #635

Comments

@ericphanson
Copy link
Collaborator

It’s tricky to do efficiently so we should have an implementation here (even though it doesn’t need a new atom). We should also speed up the sparse matrix creation in the 1D convolution.

I implemented both here: https://discourse.julialang.org/t/convex-jl-slow-in-creating-constraints/34775/31

We could also let users reuse the matrix representation as is done there.

@RoyiAvital
Copy link

The paper link you used is no longer available.
This is its archive: https://web.archive.org/web/20170809080755/https://sites.ualberta.ca/~mostafan/Files/Papers/md_convolution_TLE2009.pdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants