Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Not working with @typescript-eslint/parser v8 #3792

Open
2 tasks done
lukpsaxo opened this issue Aug 1, 2024 · 4 comments
Open
2 tasks done

[Bug]: Not working with @typescript-eslint/parser v8 #3792

lukpsaxo opened this issue Aug 1, 2024 · 4 comments

Comments

@lukpsaxo
Copy link

lukpsaxo commented Aug 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Due to : typescript-eslint/typescript-eslint#8933

accessing "typeParameters" will now be undefined.

It needs to be changed to "typeArguments" (and the other deprecations in the Pr linked above).

Expected Behavior

The result is that eslint-pugin-react doesn't find any declared props in a typescript project.

I see there is a PR to fix this: #3788 but it is about the deprecations, not the fact that eslint-plugin-react just stops working without any indication why (no errors from npm etc.)

eslint-plugin-react version

7.35.0

eslint version

v8.57.0

node version

v22

@lukpsaxo lukpsaxo added the bug label Aug 1, 2024
@lukpsaxo
Copy link
Author

lukpsaxo commented Aug 1, 2024

Note also - typescript eslint v8 is required for eslint v9, so this essentially blocks eslint v9 upgrade even though you now technically support it.

@lukpsaxo
Copy link
Author

lukpsaxo commented Aug 1, 2024

waiting on fix pr: #3629

@ljharb
Copy link
Member

ljharb commented Aug 1, 2024

This isn't really a bug, to be clear, it's just something we don't support yet - and that shouldn't be surprising since it was just released like 24 hours ago.

Indeed, #3629 blocks supporting v6, and then we can work on v7 and then v8.

@lukeapage
Copy link
Contributor

Sure - I raised this because it took me a while to figure out what was happening and having an issue open on GitHub might help other people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants