-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enhancement: Newsletter landing page #634
Comments
Hello @benjagm |
Hi @benjagm , is the issue still available to work up on . |
Akshaybagai52 and Piyusharora2003 thanks for your support. @Akshaybagai52 you was first so all yours. Thanks! |
Hey @benjagm can you tell me about how we can get previous newsletter data to show in the newsletter page and also Do I need to make the changes in design like form on right side and addition details on left side |
/assign @Ayush9026 i will solve this. |
Hi Akshay, the link to previous newsletters will be in a json or yaml file with this structure:
Use this link as reference for the newsletters: https://us8.campaign-archive.com/?e=__test_email__&u=ef8789d5789a6aff8113a701d&id=69a182f12d |
Hello Benja |
Thanks @Akshaybagai52 !! This is what I was talking about! There are some changes to be done that I am going to details in the PR. Great progress!! |
@Akshaybagai52 Are you still working on it? We can complete the last changes from our side if this is ok for you. |
Sorry I just forgot to mention you in the latest changes. You can check the latest commit and tell me if there will be any changes need to be done |
Completed with #733 |
Is your feature request related to a problem? Please describe
As part of #308 we implementer an initial version of the newsletter component that is now available in the branch web-release-3 pending to be merged to main alongside other features part of the release 3 of the docs strategy.
That initial version of the page available in /pages/newsletter is only providing a subscribe form but we'd like to make that page much more powerful by showing also a welcome message and the previously published newsletter. I do like what the CNCF did with their newsletter: https://www.cncf.io/kubeweekly/
I'd like to have something similar. The newsletter will be created in mailchimp so probably we'll need to have a json or yaml file inside the /data folder with the details of newsletters:
I do like the design of CNCF so let's do something similar. In this case I think we can use the generic card component we build using Title, Body and Link.
Describe the solution you'd like
See the feature description
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
No
The text was updated successfully, but these errors were encountered: