Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Links on Home page harder to guess in Dark Mode #1267

Open
Adi-204 opened this issue Jan 9, 2025 · 2 comments · May be fixed by #1286
Open

🐛 Bug: Links on Home page harder to guess in Dark Mode #1267

Adi-204 opened this issue Jan 9, 2025 · 2 comments · May be fixed by #1286
Assignees
@Adi-204
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Adi-204
Copy link
Contributor

Adi-204 commented Jan 9, 2025 •
edited
Loading

Describe the bug

Links on home page are underline with black which makes it harder to guess.

image

Steps To Reproduce

  1. Go to Home Page (https://json-schema.org/).
  2. Scroll down to Sponsors section

Expected Behavior

Two suggested design changes -

  1. Change underline color to white for dark mode.

  2. Change all links color to blue and underline as done in other pages. Example like text "discussing" in below screenshot
    image

Screenshots

No response

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@Adi-204 Adi-204 added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Jan 9, 2025
@Adi-204
Copy link
Contributor Author

Adi-204 commented Jan 9, 2025

Please assign me the issue I would like to contribute, which of above two suggestions I should go with.

@DhairyaMajmudar
Copy link
Member

Go ahead @Adi-204, looking forward for your PR

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 9, 2025
@Adi-204 Adi-204 linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adi-204 Adi-204

Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: URL color on homepage in dark-mode Adi-204/website
2 participants
@Adi-204 @DhairyaMajmudar