Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_parse_endpoint breaks with recent yarl versions #68

Open
mweinelt opened this issue Nov 7, 2024 · 1 comment
Open

test_parse_endpoint breaks with recent yarl versions #68

mweinelt opened this issue Nov 7, 2024 · 1 comment

Comments

@mweinelt
Copy link

mweinelt commented Nov 7, 2024

The following test broke between yarl 1.9 and 1.10.

======================================================================
FAIL: test_parse_endpoint (tests.unit.test_api.TestAPI.test_parse_endpoint)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.11/unittest/async_case.py", line 90, in _callTestMethod
    if self._callMaybeAsync(method) is not None:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/unittest/async_case.py", line 112, in _callMaybeAsync
    return self._asyncioRunner.run(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/tmp/tesla_powerwall/tests/unit/test_api.py", line 38, in test_parse_endpoint
    self.assertEqual(api.url(""), URL(ENDPOINT.rstrip("/")))
AssertionError: URL('https://1.1.1.1/api/') != URL('https://1.1.1.1/api')
@jrester
Copy link
Owner

jrester commented Nov 7, 2024

Thanks for your report! I will take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants