Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in >= React 15.3.x #19

Open
frankleng opened this issue Nov 29, 2016 · 6 comments
Open

Error in >= React 15.3.x #19

frankleng opened this issue Nov 29, 2016 · 6 comments

Comments

@frankleng
Copy link

frankleng commented Nov 29, 2016

getting

ERROR in ./~/uncontrollable/batching.js
Module not found: Error: Cannot resolve module 'react/lib/ReactUpdates' in /Code/react-rxd/node_modules/uncontrollable
 @ ./~/uncontrollable/batching.js 5:20-53

@jquense seems like you've changed the require path to use react-dom instead, but the released version on NPM is still referencing react itself.
https://github.com/jquense/uncontrollable/blob/master/src/batching.js#L1
can you cut a bug fix release?

@frankleng
Copy link
Author

quick workaround, in webpack config add

resolve: {
  alias: { 'react/lib/ReactUpdates': 'react-dom/lib/ReactUpdates' }
}

@wadim
Copy link

wadim commented Feb 20, 2017

@jquense Can you please release a new version with the switch to react-dom? It would make it so much easier for me.

@yantakus
Copy link

yantakus commented Nov 8, 2017

@frankleng's workaround won't help in case react 16 is used as there's no react-dom/lib folder anymore, it is deprecated.

@jquense
Copy link
Owner

jquense commented Nov 8, 2017

For v16 I think we'll be deprecating the batching version of uncontrollable entirely (or simplifying it), It exists to handle some odd cases around subtrees that the new createPortal api handles internally so I don't see as much of a neewd for this version of it anymore

@yantakus
Copy link

yantakus commented Nov 8, 2017

@jquense, thanks for the explanation. Any plans on releasing it in the near future?

@jquense
Copy link
Owner

jquense commented Nov 8, 2017

hopefully, tho in the meantime i'd suggest using the none batching version which works in all versions of react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants