Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarjan sort issue? #200

Open
valkheim opened this issue Nov 16, 2020 · 2 comments
Open

Tarjan sort issue? #200

valkheim opened this issue Nov 16, 2020 · 2 comments
Assignees

Comments

@valkheim
Copy link

valkheim commented Nov 16, 2020

Hi,

The Diaphora tarjan sort is had been fetched from this blog post but contains an error as suggested in the blog post scriptum:

Note 11/1/2012: Dries Verdegem reports that the above Strongly Connected Components code has a bug in it, and offers this version, which has withstood heavy testing (the graph of all Wikipedia articles!):
http://www.logarithmic.net/pfh-files/blog/01208083168/tarjan.py

@joxeankoret
Copy link
Owner

Oh, thank you! I will diff them and apply the patch. Thanks for pointing it out!

@joxeankoret joxeankoret self-assigned this Apr 10, 2023
@joxeankoret joxeankoret added this to the Diaphora 3.0 milestone Apr 10, 2023
@joxeankoret
Copy link
Owner

This is going to be implemented in Diaphora 3.1 (to be released before the end of this year).

@joxeankoret joxeankoret modified the milestones: Diaphora 3.0, Diaphora 3.1 Sep 30, 2023
@joxeankoret joxeankoret removed this from the Diaphora 3.2 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants