Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka instructions - tell user to enable sidecar injection #21

Open
jmazzitelli opened this issue Jul 28, 2022 · 0 comments
Open

kafka instructions - tell user to enable sidecar injection #21

jmazzitelli opened this issue Jul 28, 2022 · 0 comments

Comments

@jmazzitelli
Copy link

All works, except the kafka quick start instructions here should tell the user to turn on injection (it was mentioned above but not here - if someone just wants the kafka demo, they would need to know to do this).

So I suggest adding this at the start of the kafka instructions (the same instructions as you had above):

If not already done, enable istio injection:

`kubectl label namespace default istio-injection=enabled`

*Note: though not mandatory, it's the main purpose of this demo to use Istio networking rules. The demo will still run without Istio.*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant