Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize leading NA checks in C code #116

Open
joshuaulrich opened this issue Aug 22, 2021 · 0 comments
Open

Standardize leading NA checks in C code #116

joshuaulrich opened this issue Aug 22, 2021 · 0 comments
Labels
chore Stuff Josh should do but doesn't want to

Comments

@joshuaulrich
Copy link
Owner

runPercentRank() would segfault when n was larger than the number of non-NA values (fixed in #112). This bug exists in other C functions (e.g. wilderSum()), but the input is checked before calling C. These checks should be done in the C code so the functions can be called directly from C.
@joshuaulrich joshuaulrich added the chore Stuff Josh should do but doesn't want to label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Stuff Josh should do but doesn't want to
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuaulrich