Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaymentsMeans node Does not support multiple PaymentMeans. #62

Open
saqijaan opened this issue Aug 28, 2024 · 6 comments
Open

PaymentsMeans node Does not support multiple PaymentMeans. #62

saqijaan opened this issue Aug 28, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@saqijaan
Copy link

PaymentMeans on peppol BIS is 0..n which means we can add multiple payment means and Payment only support 0..1 nodes.

Currenlty library suports multiple cac:PayeeFinancialAccount nodes but only one PaymentMeans code which is invalid as we want to add multiple PaymentMeans.
@yurikuzn
Copy link

yurikuzn commented Sep 9, 2024

I was curious about this problem too.

Maybe it would be reasonable to add addPayment method and keep getPayment and setPayment for backward compatibility.

@saqijaan
Copy link
Author

Yeah it could be I was working on a PR but then got busy with an other issue. Can you help @yurikuzn if you can or we will have to either wait for @josemmo or I'll make a PR when get time.

@josemmo josemmo added the enhancement New feature or request label Sep 14, 2024
@josemmo
Copy link
Owner

josemmo commented Sep 14, 2024

ok, since everyone keeps asking for this feature, I'll add it.

josemmo added a commit that referenced this issue Sep 22, 2024
@josemmo
Added support for multiple payments
26437c2 
- Updated Invoice and Payment classes
- Updated UblReader and UblWriter classes
- Updated validation rules

> Closes #62
@josemmo
Copy link
Owner

josemmo commented Sep 22, 2024

I just pushed an update to develop implementing this feature. Could you give it a try and confirm that it works as intented?

composer require josemmo/einvoicing:dev-develop

@yurikuzn
Copy link

I tried the update. Tried using the addPayment method. Looks fine for me. But I have no enough expertise in E-Invoicing to say for sure. Thanks for your work.

@saqijaan
Copy link
Author

@josemmo I'll try it today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yurikuzn @josemmo @saqijaan