New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlap is used as step size #4

Open

carlthome opened this issue Mar 4, 2020 · 0 comments

Contributor

carlthome commented Mar 4, 2020

musicnn/musicnn/extractor.py

Line 54 in 96dd51f

for time_stamp in range(0, last_frame, overlap):

The object overlap is used as a step size when producing strided windows. Maybe it should be renamed to "hop" to clarify this. Just a suggestion!

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment