Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The code editor does not work in isolated networks #141

Open
soulruins opened this issue Nov 29, 2024 · 3 comments
Open

[BUG] The code editor does not work in isolated networks #141

soulruins opened this issue Nov 29, 2024 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@soulruins
Copy link

The code editor does not work in isolated networks (without the Internet). The permanent inscription "Loading...".

@soulruins soulruins added the bug Something isn't working label Nov 29, 2024
@jordan-dalby
Copy link
Owner

The code editor does not work in isolated networks (without the Internet). The permanent inscription "Loading...".

It's probably trying to fetch the styles for the monaco editor, I'll see what I can do.

@jordan-dalby jordan-dalby added this to the Backlog milestone Nov 29, 2024
@github-project-automation github-project-automation bot moved this to Backlog in ByteStash Nov 29, 2024
@jordan-dalby jordan-dalby modified the milestones: Backlog, Triage Nov 29, 2024
@raghuscsa316
Copy link

I had this same problem but managed to solve this by hosting my own CDN. I only needed to stage a few files locally, so it was pretty quick and easy
loader.js
editor/editor.main.css
editor/editor.main.js
editor/editor.main.nls.js

I made all these files available locally via https://mywebserver/cdn/ (so the resources were available as https://mywebserver/cdn/loader.js, https://mywebserver/cdn/editor/editor.main.css etc)
then I updated the jsdeliver URL in /client/build/assets/index-BOq81OYO.js to my CDN base url (The file name is valid as of v1.5.3. I believe it is generated randomly at compile time so a future version might have a different filename. Best way to check would be from your browsers developer console network section)
Then all worked fine.

Bonus tip - believe some non essential elements also break when using a webroot (i.e the BASE_PATH env variable when using the docker container). For example in the index.html page, the below failed to load till I edited to used
/mywebroot/logo192.png
/mywebroot/manifest.json
/mywebroot/favicon.ico

Overall my solutions are pretty hacky, so I didn't do a PR. I also think OIDC does not work when using a webroot (about to create a new issue for that)

@jordan-dalby
Copy link
Owner

@raghuscsa316
Nice work!

Ah yes, OIDC will not work because the link does not consider the BASE_PATH, should be a relatively easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

3 participants