Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Option to make public less public #124

Open
WirtsLegs opened this issue Nov 25, 2024 · 3 comments
Open

[FEATURE] Option to make public less public #124

WirtsLegs opened this issue Nov 25, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@WirtsLegs
Copy link

Is your feature request related to a problem? Please describe.
Currently a unauthenticated user is able to browse public snippets, but I would like the ability to restrict that to logged in users in general,

Describe the solution you'd like
Config option to require a user to authenticate to see any snippets,

Ideally this could extend to having groups from the idp provider determine permissions, eg if user has group A they log in and it provisions a user for them, they can see public snippets, and if user is group B they just get to view public snippets (no creation for them)

However a simple win for now would simply be a config option to disbale public viewing for unauthenticated users

Describe alternatives you've considered
Not much for alternatives, could stick it behind a SSO proxy like OAUTH2-proxy and do auth there but that defeats the point of the integrated SSO support

Additional context
No additional context

@WirtsLegs WirtsLegs added the enhancement New feature or request label Nov 25, 2024
@arcoast
Copy link

arcoast commented Nov 25, 2024

I'd quite like to see this two, I'm currently using Opengist but Bytestash has a much nicer UI, I currently use my Opengist instance to share code snippets with a friend. I'd also like the ability to require a login to view "public" snippets.

I think essentially a third tier

  • public
  • shared
  • private

@jordan-dalby
Copy link
Owner

jordan-dalby commented Nov 25, 2024

@arcoast
Are we thinking another view for shared snippets like the public view area or are we locking down the public section to just be private?

  • PUBLIC_VIEW_REQUIRES_AUTH=true
    • private, public -> shared
    • or
    • private, public, shared

Perhaps a different name than shared, that could get confusing with the existing shared functionality

@github-project-automation github-project-automation bot moved this to Backlog in ByteStash Nov 26, 2024
@jordan-dalby jordan-dalby added this to the Backlog milestone Nov 26, 2024
@WirtsLegs
Copy link
Author

think either approach is fine, a very robust solution would be

  1. implement public view requires auth option
  2. additionally add ability to explicitly share with other users

regarding (1) if possible as a followon id love to see an option to tie that into SSO as i mentioned above, being able to have users with a given group able to view public snippets but not create their own, then users in another group able to do both would be a big win

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants