-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2]Wrong locale on installation #44667
Comments
Sorry but I can't reproduce this in my local test environment with 5.2.3 RC 1. Tested with Chrome, Firefox and Safari. |
Can't confirm too (Mac, Firefox). |
@tecpromotion I assume as you tested with safari that you are like @fgsw testing on a Mac and not the reported issue on Windows |
That's right. But I have already written to Rolf. We will try to reproduce this in the German-speaking community. Maybe we'll find out something. |
@dautrich @tecpromotion @fgsw Could you inspect the request header for the "GET" request in the network traffic analysis of your browser's developer tools? There should be an See e.g. screenshot from my browser (German Firefox latest version on Windows): In my case the value is You can test that with any GET request to any (valid) URL. Please check and report back your values for that |
@richard67 Firefox is set to English, for this test preferred Language on "German [de]", give: |
@fgsw Hmm, so in your case it finds the right language even if your header has no "de-DE", only "de". The ordering of the list field in the form is so that "de-AT" comes before "de-DE", so it seems in your case it does not just pick the first "de-something" which it can find. Strange. So we have to wait what @dautrich reports for the case in which he can reproduce the issue. |
@dautrich So in your case as well as in @fgsw 's you don't have a "de-DE", only "de", but in opposite to him you have "en-US". What happens if you either modify the header in the developer tools or if you change the settings as shown in following screenshots? I think in your case the one at the top is missing. But you can add it and move it to the top with that dialogue. |
So that is at least a feasible workaround. If we have an issue or not I don’t really know. But it seems weird to me that in your case with the issue de-AT was used and in @fgsw ‘s case de-DE. It would need to check the code to see how it works. |
P.S. I don’t really remember if the de-DE language was in my Firefox settings by default or if I once had added it myself. |
@richard67 Would it be possible to default to "Deutsch (Deutschland)", if the first language in the Accept-Language list is "de"? |
That’s what I would expect. But the question is what shall happen if only de is given and not de-DE: Shall it take the first de-something which it can find in alphabetical order? Then it would be de-AT. Or shall it take the primary country associated with a particular language? That would be de-DE in case of German, and for English orbother languages it would be debatable, and that would require a list of what is the primary country for each language. |
That would require some kind of a hard-coded list to define the primary country (or language with country) for each language in the one or the other way (associated list or just list of preferred language-country code). And e.g. in case of English, where in opposite to German the country with the most speakers is not the same as the country where the language comes from, it would be debatable if GB or US should be the country. But I agree that it would be more understandable if it was either the country with the most speakers or the country where the language origins instead of just picking the first alphabetical match like de-AT in case if only de is given, or en-AU if only en is given in the header. |
IMHO, there are two aspects:
|
Sure it is technically possible. So 2. is the interesting question: Who decides? |
In case of English, most software I know uses US as default because that has meanwhile become the new standard in English lessons in the world and has more speakers, as it seems. In my school days Oxford English was the standard. But as we use en-GB as default CMS language, I would suggest to default to en-GB to be consistent with that and not to en-US, if we decide to implement a solution. |
No, that does not cover all cases. A solution should cover all possible codes available in standards, so I does not need to update it whenever a new language is added to the CMS. For example Farsi is spoken in Iran and in Pakistan, Urdu is spoken in Pakistan and I think also in parts of Afghanistan, Hindi and Tamil are spoken not only in India, and so on. |
Also my opinion, so i would move this thread to "Discussions". @richard67 If for Example "German [de]" is set as preferred Language, i suggest a "easy as possible" solution which seems the alphabetic ordering. |
Other question: This affects only the installation process, nothing else. |
Well, I'm ok with leaving it as it is. My above comments were just for the case that there is common sense to do something. @dautrich Ok to close the issue as expected behaviour? |
In principle, I agree to @chmst's post. However, it's a bit strange for a Joomla user to be offered a (for him) wrong locale at his very first contact with his new Joomla site. And @richard67: I'm okay with defining that as expected behavior. We now know the reason for this effect and how to cope with it. |
Please don't clutter the installation pages. If you wan't add a note on Docs: Installing Joomla in the second Paragraph:
|
That obviously is a good statement from the technical point of view. But my point is about psychology: Think about a newbie at his first Joomla installation. The very first thing he/she sees may be a "wrong" locale identification. This won't increase the user's confidence in the new software. That's why I would like to have a remark on the installation page. You and I will simply ignore the message. |
Why not replace the de-AT by either simple "de" or even better "German"? |
Good Solution cause it solves another issue too: |
Steps to reproduce the issue
Expected result
The installation language is displayed as “German (Germany) | Deutsch (Deutschland)”.
Actual result
The installation language is displayed as “German (Austria) | Deutsch (Österreich)”.
System information (as much as possible)
Windows 11 (Home or Pro)
Firefox 133.0.3 (or earlier) or Microsoft Edge 131.0.2903.112 (or earlier)
Additional comments
No issue with Google Chrome (tested on 131.0.6778.205)
I have seen set since the first J5 releases and already had a discussion with @tecpromotion about that topic in February 2024.
The text was updated successfully, but these errors were encountered: