Kubetail kills parent shell

[wknapik]

If you call kubetail from a script, it will kill the script when it's done.

% sh -c 'echo shell pid $$; kubetail -k false -f false -s 1s >/dev/null; echo foo'
shell pid 31337
[1]    31337 terminated  sh -c 
%

This forces the user to trap TERM, to avoid failure during successful execution and consequently messes up signal handling in that script, which won't die when sent TERM from elsewhere.

See: https://github.com/johanhaleby/kubetail/blob/master/kubetail#L277

[wknapik]

Kubetail should kill its children before exiting, instead of killing the entire process group.

[johanhaleby]

@wknapik That makes sense. Could you help out with this?

[wknapik]

@johanhaleby if it was a small fix, I'd submit a PR, but there's too much to change before this can be done properly.

I'd recommend cleaning up shellcheck findings and dropping the eval. Then fixing this will be easy.

[pmorch]

Other symptoms:

$ kubetail $args | less
<some output, but ends prematurely>

$ echo $?
15

Instead, I need to:

kubetail $args > file && less file

or better:

less -f <(kubetail $args)

This also fails:

$ kubetail $args | tail
[1]    7136 done        kubetail $args | 
       7137 terminated  tail

$ echo $?
143