Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu translation #28

Open
xt0ph opened this issue Dec 28, 2023 · 2 comments
Open

Menu translation #28

xt0ph opened this issue Dec 28, 2023 · 2 comments

Comments

@xt0ph
Copy link

xt0ph commented Dec 28, 2023

Is there a plan to translate the menu entries?
I could offer you a PR if you want.

@jluttine
Copy link
Owner

I haven't had such plans but sounds good to me. 👍 Could you describe how you'd implement it? I suppose, the script would check the language from locale settings? But this could perhaps be explicitly overridden by a CLI argument?

@xt0ph
Copy link
Author

xt0ph commented Dec 28, 2023

Yes, I check the language from locale settings. I had not thought of proposing the override by a parameter but it is easily achievable.
For the moment I'm still wondering where to put the files for the different languages. I was thinking of separating them from the script, but the installation will be less easy than now. Putting the translations in the script requires a modification for each new language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants